Skip to content

Conversation

@krissetto
Copy link
Contributor

No description provided.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurazard PTAL

-----
### Upgrade Notes
- Bumped minimum engine API version to 1.24
- Bumped default engine API version to 1.44 (Moby 25.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #3261 is planned to get merged for 7.1.0, this needs to be updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were discussing that one, and maybe (given that there may still be some questions remaining there), we should skip that one for now, and leave it for the next release.

Copy link
Contributor

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of nits (just removing periods as I don't think we tend to use them, I might've left them there myself though 😅), but otherwise LGTM.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
@laurazard laurazard enabled auto-merge May 23, 2024 09:31
@laurazard laurazard merged commit 20879ec into docker:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore Refactor, linter, CI, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants