Channel Check/Fade Range per-address priority #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #349.
Added a new "Mask others" checkbox to both channel check and fade range with a tooltip that explains what it does. Feedback welcome on the label; I tried to find something very short that would fit nicely around the existing widgets. Hopefully the translators can write something similarly short!
When masking others, all addresses have their priority set to 0 except for those affected by the current tab which have their priority set to whatever is configured in the address priority dialog.
Had to do a little refactoring in
sACNSentUniverseto make setting priorities work similarly to setting levels. Originally the priorities buffer was only read once when beginning transmitting; now it works like setting levels such that changes are reflected without restarting the transmitter.