cache some metadata state to avoid querying all the time the database… #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d48de9 to
6cda2e0
Compare
greg0ire
approved these changes
Apr 24, 2021
Member
|
Ah there are tests failures now |
6cda2e0 to
6e84944
Compare
6e84944 to
af63b46
Compare
Member
Author
|
now it should be better! :) (ive also added tests) |
stof
reviewed
Apr 28, 2021
|
|
||
| private function isInitialized(): bool | ||
| { | ||
| if ($this->isInitialized) { |
Member
There was a problem hiding this comment.
shouldn't you also memoize the result of tablesExist, and distinguish null vs false (we know it is not initialized yet) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… schema