Skip to content

No finder sort #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greg0ire merged 1 commit into from
Jul 3, 2021
Merged

No finder sort #1173

greg0ire merged 1 commit into from
Jul 3, 2021

Conversation

@goetas
Copy link
Member

@goetas goetas commented Jun 29, 2021

Q A
Type improvement
BC Break no
Fixed issues #1172

@goetas
Copy link
Member Author

goetas commented Jun 29, 2021

The phpunit failure is weird...

@greg0ire
Copy link
Member

greg0ire commented Jul 3, 2021 •
edited
Loading

It's not that weird, see #1175 🙂

@greg0ire greg0ire closed this Jul 3, 2021
@greg0ire greg0ire reopened this Jul 3, 2021
@greg0ire
Copy link
Member

greg0ire commented Jul 3, 2021

I think it needed a rebase to pass on AppVeyor too, hence my force push 🤚

@greg0ire greg0ire added the Bug label Jul 3, 2021
@greg0ire greg0ire merged commit 537a847 into 3.1.x Jul 3, 2021
@greg0ire greg0ire deleted the no-finder-sort branch July 3, 2021 20:49
@greg0ire
Copy link
Member

greg0ire commented Jul 3, 2021

Thanks @goetas !

@goetas
Copy link
Member Author

goetas commented Jul 4, 2021

this change relates to 5c3ceed

@goetas goetas added this to the 3.1.5 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

3.1.5

Development

Successfully merging this pull request may close these issues.

3 participants

@goetas @greg0ire