Skip to content

Conversation

@derrabus
Copy link
Member

No description provided.

@derrabus derrabus added the Tests label Apr 22, 2022
@derrabus derrabus added this to the 3.5.1 milestone Apr 22, 2022
@stof
Copy link
Member

stof commented Apr 22, 2022

This effectively means that the CI cannot run tests with ORM 2.11 (even though it does not do it right now, as there is no job running PHPUnit against lowest deps in the matrix), while still telling composer that there is no issue using them together.

I suggest adding a conflict rule (same than in doctrine/data-fixtures#393 (comment) btw)

@derrabus derrabus force-pushed the improvement/orm-setup branch from 726f75d to 247efcb Compare May 3, 2022 00:28
@greg0ire greg0ire force-pushed the improvement/orm-setup branch from 247efcb to c464fb1 Compare May 9, 2022 20:18
@greg0ire
Copy link
Member

greg0ire commented May 9, 2022

Fixed the cs issues 🙂

@greg0ire greg0ire merged commit 5dac566 into doctrine:3.5.x May 9, 2022
@greg0ire
Copy link
Member

greg0ire commented May 9, 2022

Thanks @derrabus !

@derrabus derrabus deleted the improvement/orm-setup branch May 9, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants