Skip to content

PHPStan: Remove obsolete rule #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derrabus merged 1 commit into from
Jun 26, 2024
Merged

PHPStan: Remove obsolete rule #1437

derrabus merged 1 commit into from
Jun 26, 2024

Conversation

@derrabus
Copy link
Member

@derrabus derrabus commented Jun 26, 2024

Q A
Type chore
BC Break no
Fixed issues none

Summary

This rule is obsolete after the Persistence 3.3.3 release. Removing it fixes our CI.

@derrabus derrabus added this to the 3.7.5 milestone Jun 26, 2024
@derrabus derrabus requested a review from greg0ire June 26, 2024 08:32
@derrabus derrabus mentioned this pull request Jun 26, 2024
Merged
@derrabus derrabus merged commit b60aed2 into doctrine:3.7.x Jun 26, 2024
@derrabus derrabus deleted the chore/get-services branch June 26, 2024 08:34
derrabus added a commit that referenced this pull request Jun 26, 2024
@derrabus
Merge branch '3.7.x' into 3.8.x
87a7ce0 
* 3.7.x:
  PHPStan: Remove obsolete rule (#1437)
  Bump doctrine/.github from 4.0.0 to 5.0.1 (#1429)
  Bump ramsey/composer-install from 2 to 3 (#1428)
  Setup Dependabot for Github actions
  Upgrade codecov/codecov-action
derrabus added a commit that referenced this pull request Jun 26, 2024
@derrabus
Merge branch '3.8.x' into 4.0.x
2a6b096 
* 3.8.x:
  PHPStan: Remove obsolete rule (#1437)
  Freeze migrations before executing sql
  Bump doctrine/.github from 4.0.0 to 5.0.1 (#1429)
  Bump ramsey/composer-install from 2 to 3 (#1428)
  Setup Dependabot for Github actions
  Upgrade codecov/codecov-action
  Ask for a namespace of when more one path
@derrabus derrabus modified the milestones: 3.7.5, 3.8.0 Jun 26, 2024
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees

No one assigned

Labels

Static Analysis

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

1 participant

@derrabus