Throw an exception if addSql is used in post methods #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f88c94 to
f60b117
Compare
greg0ire
approved these changes
Jun 3, 2024
Member
|
Why are you targeting 3.7.x 🤔 That's not a bugfix, is it? |
Contributor
Author
I target the stable/default branch by habit. ^^ |
SenseException
approved these changes
Jun 6, 2024
f60b117 to
44d34d6
Compare
Member
|
Thanks @VincentLanglet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using
addSqlin post methods should be reported since the sql will be ignored during the migration.