Repository navigation
Evaluate if we should return iterable instead of array in some cases #60
Description
Activity
I don’t think adding methods to the interface is a good idea, as it requires duplicating logic. IMO the only reason not to do it is “it’s a tough BC break”. However, I don’t think that’s a valid argument as breaking BC again is difficult for a package this low in the dependency food chain.
Hi,
Just adding my 2 cents here to an old topic.
I don't see the point of doing this, as long as the PDO Driver doesn't return an iterator.
When querying a DB, the whole resultset is returned at once and I don't see why we should create an iterator out of it, it's already loaded in the memory.
@drupol what's your take on https://www.dragonbe.com/2015/07/speeding-up-database-calls-with-pdo-and.html ?
Reacted by Pol DellaieraI was not aware of
PDOSTatement::fetch()but I think the post make sense if we use it.I think the default in Doctrine is
PDOSTatement::fetchAll()right, do you confirm ?I do not confirm and I reject the burden of proof 😛
Then ok, fair enough. I'll investigate a bit this thing. The idea of having an iterator makes a lot of sense to me !
Reacted by Grégoire Paris
findAllIterator()or something instead of changingfindAll()to return an array.