This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Update dependencies for CI build #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspat
reviewed
Dec 3, 2019
|
|
||
| /** | ||
| * @return string[]|bool[] | ||
| * @return array<array<bool|string>> |
Contributor
There was a problem hiding this comment.
This can be also annotated as
Suggested change
| * @return array<array<bool|string>> | |
| * @return string[][]|bool[][] |
That way not only static-analysis tools but PHPStorm will understand it too.
Member
There was a problem hiding this comment.
In this case, this should be avoided: the signature you proposed translates to array<array<bool>>|array<array<string>>, which is a different type
Member
Author
There was a problem hiding this comment.
That is not the same though. The array<...> syntax allows for an array like this:
[
['foo', true],
[true],
]
The "PHPStorm compatible" type does not properly allow for this.
Contributor
There was a problem hiding this comment.
Oh, didn't know that nuance, thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in a newer PHPStan version that allows us to simplify the call by configuring paths and level in phpstan.neon.dist.