Update java build to java jdk 25#1097
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughUpdates four GitHub Actions workflows to use Java 25 instead of Java 17 or 21 for CI/CD jobs including build testing, code analysis, and Maven publishing. ChangesJava 25 CI/CD upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/build-tests.yml (1)
148-148:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove unnecessary JAVA_HOME from symbol-test job.
The
symbol-testjob setsJAVA_HOME: /usr/lib/jvm/java-17-openjdk-amd64, but the job only runs grep and diff commands to extract and compare JNI symbol names—it does not compile or execute Java code. The environment variable is unused and should be removed entirely rather than updated to match the Java 25 upgrade in thebuild-testjob.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/build-tests.yml at line 148, The symbol-test job sets an unused environment variable JAVA_HOME; remove the JAVA_HOME: /usr/lib/jvm/java-17-openjdk-amd64 entry from the symbol-test job definition so the job no longer defines JAVA_HOME (look for the symbol-test job block and the JAVA_HOME env entry to delete).
♻️ Duplicate comments (3)
.github/workflows/code-analysis.yml (1)
24-28:⚠️ Potential issue | 🟠 Major | ⚡ Quick winVerify Java 25 availability with the 'adopt' distribution.
Confirm that Java 25 is available through
actions/setup-java@v4with the 'adopt' (Eclipse Adoptium) distribution before merging.Is Java 25 available through Eclipse Adoptium for GitHub Actions?🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/code-analysis.yml around lines 24 - 28, The workflow step "Set up JDK 25" uses actions/setup-java@v4 with java-version: 25 and distribution: 'adopt' which may be invalid; verify that Java 25 is actually provided by the chosen distribution and update the step accordingly (either change distribution to a supported one like 'temurin' or 'zulu', or remove/adjust java-version if 25 is not available). Edit the workflow entry that references uses: actions/setup-java@v4 and java-version: 25 / distribution: 'adopt' to use a valid distribution string or supported Java version..github/workflows/code-analysis-pull.yml (1)
102-106:⚠️ Potential issue | 🟠 Major | ⚡ Quick winVerify Java 25 availability with the 'adopt' distribution.
Ensure that Java 25 is available through
actions/setup-java@v4with the 'adopt' (Eclipse Adoptium) distribution for this workflow.Does Eclipse Adoptium provide Java 25 builds compatible with actions/setup-java@v4?🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/code-analysis-pull.yml around lines 102 - 106, The workflow currently requests Java 25 via actions/setup-java@v4 using distribution: 'adopt', but Eclipse Adoptium no longer uses the 'adopt' identifier and may not provide Java 25 builds under that name; update the setup step referencing actions/setup-java@v4 to use distribution: 'temurin' (the correct Adoptium identifier) or remove the distribution key to use the default, and confirm that java-version: 25 is supported by actions/setup-java@v4 with the chosen distribution before merging; locate the step that sets java-version: 25 and distribution: 'adopt' to make this change..github/workflows/publish.yml (1)
25-29:⚠️ Potential issue | 🟠 Major | ⚡ Quick winVerify Java 25 availability with the 'adopt' distribution.
Confirm that Java 25 is available through
actions/setup-java@v4with the 'adopt' (Eclipse Adoptium) distribution for the Maven publishing workflow.Is Java 25 supported by Eclipse Adoptium distribution in GitHub Actions setup-java action?🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/publish.yml around lines 25 - 29, Confirm whether actions/setup-java@v4 supports java-version '25' with distribution 'adopt' and if not, update the workflow to use a supported distribution and/or Java version: locate the actions/setup-java@v4 step that sets java-version: '25' and distribution: 'adopt', verify upstream support for Java 25 under the 'adopt' name, and if unsupported replace the distribution with the current Eclipse Temurin identifier (e.g., 'temurin') or switch java-version to a supported release; then run the workflow locally/CI to ensure the publishing job succeeds.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-tests.yml:
- Around line 44-45: The workflow currently configures java-version: '25' in the
actions/setup-java step but later installs package openjdk-21-jdk via apt-get,
causing a version mismatch; update the apt-get install command that references
openjdk-21-jdk to install openjdk-25-jdk so the installed system JDK matches the
actions/setup-java java-version: '25' entry and keep the workflow consistent
with other pipelines.
---
Outside diff comments:
In @.github/workflows/build-tests.yml:
- Line 148: The symbol-test job sets an unused environment variable JAVA_HOME;
remove the JAVA_HOME: /usr/lib/jvm/java-17-openjdk-amd64 entry from the
symbol-test job definition so the job no longer defines JAVA_HOME (look for the
symbol-test job block and the JAVA_HOME env entry to delete).
---
Duplicate comments:
In @.github/workflows/code-analysis-pull.yml:
- Around line 102-106: The workflow currently requests Java 25 via
actions/setup-java@v4 using distribution: 'adopt', but Eclipse Adoptium no
longer uses the 'adopt' identifier and may not provide Java 25 builds under that
name; update the setup step referencing actions/setup-java@v4 to use
distribution: 'temurin' (the correct Adoptium identifier) or remove the
distribution key to use the default, and confirm that java-version: 25 is
supported by actions/setup-java@v4 with the chosen distribution before merging;
locate the step that sets java-version: 25 and distribution: 'adopt' to make
this change.
In @.github/workflows/code-analysis.yml:
- Around line 24-28: The workflow step "Set up JDK 25" uses
actions/setup-java@v4 with java-version: 25 and distribution: 'adopt' which may
be invalid; verify that Java 25 is actually provided by the chosen distribution
and update the step accordingly (either change distribution to a supported one
like 'temurin' or 'zulu', or remove/adjust java-version if 25 is not available).
Edit the workflow entry that references uses: actions/setup-java@v4 and
java-version: 25 / distribution: 'adopt' to use a valid distribution string or
supported Java version.
In @.github/workflows/publish.yml:
- Around line 25-29: Confirm whether actions/setup-java@v4 supports java-version
'25' with distribution 'adopt' and if not, update the workflow to use a
supported distribution and/or Java version: locate the actions/setup-java@v4
step that sets java-version: '25' and distribution: 'adopt', verify upstream
support for Java 25 under the 'adopt' name, and if unsupported replace the
distribution with the current Eclipse Temurin identifier (e.g., 'temurin') or
switch java-version to a supported release; then run the workflow locally/CI to
ensure the publishing job succeeds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a9e0848a-0678-4838-b002-dea879d1dde6
📒 Files selected for processing (4)
.github/workflows/build-tests.yml.github/workflows/code-analysis-pull.yml.github/workflows/code-analysis.yml.github/workflows/publish.yml
KEM algorithms are supported from Java 23 so the jdk has to be updated in order to build the code.
edewata
left a comment
There was a problem hiding this comment.
I think the Java versions in jss.spec need to be updated as well in case we need to build for other platforms, but this PR LGTM.
KEM algorithms are supported from Java 23 so the jdk has to be updated in order to build the code.
Summary by CodeRabbit
Chores