Skip to content

Rename app-json:report flags to match property#8601

Merged
josegonzalez merged 1 commit into
masterfrom
8598-app-json-set-appjson-path-succeeds-but-app-json-appjson-path-is-not-a-valid-report-flag
May 11, 2026
Merged

Rename app-json:report flags to match property#8601
josegonzalez merged 1 commit into
masterfrom
8598-app-json-set-appjson-path-succeeds-but-app-json-appjson-path-is-not-a-valid-report-flag

Conversation

@josegonzalez
Copy link
Copy Markdown
Member

The property name set via app-json:set is appjson-path, but the matching read-back flags on app-json:report were named --app-json-selected, --app-json-global-selected, and --app-json-computed-selected. The mismatch meant dokku app-json:report <app> --app-json-appjson-path (the form already documented in deployment-tasks.md) was rejected as an invalid flag, and the --format json output advertised keys that did not correspond to any settable property. The flags and JSON keys are renamed to --app-json-appjson-path, --app-json-global-appjson-path, and --app-json-computed-appjson-path so that the property name round-trips through set and report.

Fixes #8598.

The property name set via `app-json:set` is `appjson-path`, but the matching read-back flags on `app-json:report` were named `--app-json-selected`, `--app-json-global-selected`, and `--app-json-computed-selected`. The mismatch meant `dokku app-json:report <app> --app-json-appjson-path` (the form already documented in deployment-tasks.md) was rejected as an invalid flag, and the `--format json` output advertised keys that did not correspond to any settable property. The flags and JSON keys are renamed to `--app-json-appjson-path`, `--app-json-global-appjson-path`, and `--app-json-computed-appjson-path` so that the property name round-trips through set and report.
@josegonzalez josegonzalez changed the title fix: rename app-json:report flags to match property Rename app-json:report flags to match property May 11, 2026
@josegonzalez josegonzalez merged commit cdce68f into master May 11, 2026
106 of 109 checks passed
@josegonzalez josegonzalez deleted the 8598-app-json-set-appjson-path-succeeds-but-app-json-appjson-path-is-not-a-valid-report-flag branch May 11, 2026 03:58
github-actions Bot pushed a commit that referenced this pull request May 11, 2026
# History

## 0.38.3

Install/update via the bootstrap script:

```shell
wget -NP . https://dokku.com/install/v0.38.3/bootstrap.sh
sudo DOKKU_TAG=v0.38.3 bash bootstrap.sh
```

### Bug Fixes

- #8602: @josegonzalez Reject per-app sets for global-only proxy properties
- #8601: @josegonzalez Rename app-json:report flags to match property
- #8600: @josegonzalez Report info-flag should not error when app undeployed

### New Features

- #8599: @josegonzalez Add docker healthcheck to dokku container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app-json:set appjson-path succeeds but --app-json-appjson-path is not a valid report flag

1 participant