[wsi] Handle SDL3 refresh rate not being available #4825
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
approved these changes
Apr 3, 2025
Owner
doitsujin
left a comment
There was a problem hiding this comment.
Is the refresh_rate float being non-zero while numerator is zero something that actually intended behaviour? I was assuming the float to be more of a convenience thing that would be there in addition to the rational, but this doesn't seem to be very well documented.
Either way, patch looks good.
Contributor
Author
|
I believe so, and I think this is just inherited from SDL2 only having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SDL3 it's possible for the platform to refuse returning a good refresh rate, so we have to try as many options as we can. Numerator/Denominator is best, but sometimes we just get a float, and sometimes we don't even get that (I managed to repro this via Xwayland).
This ensures that if the WsiRational is ever invalid, it's almost certainly SDL's fault rather than dxvk's.