Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a timeout issue when syncing content to Jianshu platform by improving the tab loading detection logic and extending timeout duration.
Related Issue
N/A
Type of Change
Changes Made
waitForTabtimeout from 3000ms to 6000ms for slower-loading pagesImplementation Details
Problem
When syncing to Jianshu, the tab loading sometimes takes longer than expected, especially when third-party resources (ads, trackers, etc.) fail to load or timeout. The original logic waited for tab status to be 'complete', which could hang indefinitely or timeout prematurely.
Key Changes
!tabcondition toif (platformId !== 'wechat' && !tab)to prevent unnecessary tab creationTechnical Notes
Testing
Testing Checklist
Manual Testing Steps
Reviewer Checklist