Do not instantiate ActiveRecord model early #1708
Open
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not instantiate active record models before loading active record, as it can cause several side effects. Fixes doorkeeper-gem#1703
Member
|
I remember we already had such hook and it also lead to a lot of issues, unfortunately. I believe we can find them in the issues section |
nbulaj
approved these changes
Jun 2, 2024
Member
nbulaj
left a comment
There was a problem hiding this comment.
Well, let's try to use AS hooks once again 🤞
Member
|
Can you please add a changelog entry? |
Author
|
I checked the old issues and found that active support hooks caused issues
for STI loading. So I wanted to add tests for that before
proceeding further. But I haven't got time for that yet.
…On Mon, 3 Jun, 2024, 12:39 am Nikita Bulai, ***@***.***> wrote:
Can you please add a changelog entry?
—
Reply to this email directly, view it on GitHub
<#1708 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXYAEE6QU6RAQX7NQWN2PLZFNUVFAVCNFSM6AAAAABHS56NPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHE4DSOJRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Hello @tachyons . maybe any updates on that? 👁️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not instantiate active record models before loading active record, as it can cause several side effects.
Fixes #1703