Sort adaptive encoding columns by size for out-of-band storage#10919
Merged
Conversation
BuildPermissive now moves the largest adaptive values out-of-band first instead of visiting columns in order, keeping smaller values inline when possible. This produces shorter tuples when columns vary in size. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This will currently change how we write rows with adaptive encoding columns. Rows written on older versions of Dolt can still be read, but writing them back will result in a new chunk hash. But since Dolt currently doesn't use adaptive encoding and Doltgres is in beta, that's acceptable.
Claude's Summary
Test plan