When merging, use a tuple builder to ensure that we generate the correct representation for the merged row.#10959
Merged
Merged
Conversation
…ect representation for the merged row. This matters for adaptive encoding columns, whose correct representation depends on other values in the row.
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
…raint violations instead of panicking.
Contributor
|
@nicktobey DOLT
|
zachmu
approved these changes
Apr 29, 2026
| } | ||
|
|
||
| if isEqual(ctx, m.leftVD.Comparator(), i, leftCol, rightCol, resultType) { | ||
| // TODO: This used to use m.leftVD[i]. Was there a bug there we weren't catching? |
Member
There was a problem hiding this comment.
Probably a good time to come up with a test case
| // To achieve this, we sort the two values and return the higher one. | ||
| if bytes.Compare(leftCol, rightCol) > 0 { | ||
| return leftCol, false, nil | ||
| return returnleftValue() |
Member
There was a problem hiding this comment.
How certain are you these are semantically equivalent? I'm a little concerned that we're introducing closure semantics here that will make it more difficult to reason about the values returned from these calls
Co-authored-by: Zach Musgrave <zach@dolthub.com>
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matters for adaptive encoding columns, whose correct representation depends on other values in the row.