clean up docs, tests, and refactor read pandas#144
Merged
Conversation
- remove Sphinx and docs - remove redundant tests that now are in doltcli - make Pandas reads use new doltcli ability to inject file parser to improve perf - bump doltcli dep
max-hoffman
approved these changes
Mar 26, 2021
| more-itertools = "^8.6.0" | ||
| mysql-connector-python = "^8.0.20" | ||
| doltcli = "0.1.2" | ||
| doltcli = "^0.1.4" |
Contributor
There was a problem hiding this comment.
did we skip a version?
Contributor
Author
There was a problem hiding this comment.
I committed 1.0.3 forgetting that the release process bumped the version... seemed inconsequential to skip a patch increment.
Contributor
There was a problem hiding this comment.
skipping 0.1.3 is fine, releasing 1.0.3 would be somewhat disruptive
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
===========================================
- Coverage 55.06% 41.95% -13.12%
===========================================
Files 25 23 -2
Lines 1718 963 -755
===========================================
- Hits 946 404 -542
+ Misses 772 559 -213
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes: