Add max connections and password capabilities.#151
Merged
Conversation
Contributor
|
Adding a test to avoid a decrease in coverage % would be nice, but otherwise looks good. |
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 41.95% 42.57% +0.62%
==========================================
Files 23 23
Lines 963 970 +7
==========================================
+ Hits 404 413 +9
+ Misses 559 557 -2
Continue to review full report at Codecov.
|
max-hoffman
reviewed
Apr 23, 2021
| f"mysql+mysqlconnector://{user}@{host}:{port}/{database}", | ||
| echo=self.server_config.echo, | ||
| ) | ||
| if password: |
Contributor
There was a problem hiding this comment.
is password is not None
max-hoffman
approved these changes
Apr 23, 2021
max-hoffman
left a comment
Contributor
There was a problem hiding this comment.
lgtm, in the future add tests if you add lines of code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces ability to connect with mysql with a password as well as introduces the max_connections flag.