Backport some of Debian patches #3662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsweeney
reviewed
Sep 22, 2025
| public function loadFontFamilies() | ||
| { | ||
| $file = $this->options->getRootDir() . "/lib/fonts/installed-fonts.dist.json"; | ||
| $file = $this->options->getFontDir() . "/installed-fonts.dist.json"; |
There was a problem hiding this comment.
I'd have to think on this one more. The purpose of this particular line of code was to pull the distributed JSON to ensure Dompdf always has a baseline of supported fonts. The generated JSON file can override that, but there's no guarantee that it will include the ".dist" file.
There was a problem hiding this comment.
Ah I see
since there is different install paths I had to change this line. I also need to think about it for the composer version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports some of my changes from Debian: https://udd.debian.org/patches.cgi?src=php-dompdf&version=3.1.0%2Bdfsg-1
I can remove the ones you do not like, this is to try to have less patches to rebase on each version