[FEAT] Make NanoId a struct #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 21 files ±0 21 suites ±0 43s ⏱️ -1s Results for commit 21c453f. ± Comparison against base commit 8657270. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
.NET Code Coverage
Code Coverage SummaryCode Coverage Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the
NanoIdvalue type, focusing on enhanced (de)serialization support, nullability handling, and code simplification. It also introduces a new extensible YAML type converter attribute and updates related persistence abstractions to support these changes. The most important changes are grouped below.Serialization and Type Conversion Enhancements
NanoIdJsonConverterandNanoIdYamlConverterto enable seamless JSON and YAML (de)serialization ofNanoIdvalues, and decorated theNanoIdstruct with the appropriate attributes for automatic converter registration. (NanoId.cs,Dosaic.Extensions.NanoIds.csproj, [1] [2]YamlTypeConverterAttributeandIYamlConverterinDosaic.Hosting.Abstractions.Attributes, and updated YAML serialization extensions to support type-based converter discovery. (YamlTypeConverterAttribute.cs,SerializationExtensions.cs, [1] [2]NanoId Struct Improvements
NanoIdfrom a class to a readonly struct, improved nullability handling (e.g.,Parsenow returnsNanoId?), simplified equality and comparison logic, and removed support for inheritance. (NanoId.cs, [1] [2] [3] [4]NanoIdTests.cs, [1] [2] [3] [4] [5] [6] [7] [8] [9]Persistence Model and Database Changes
IAuditableModelandAuditableModelto makeModifiedBynullable (NanoId?), and removed default non-null assignment forCreatedBy. (IAuditableModel.cs,AuditableModel.cs, [1] [2]NanoIdchanges and ensure correct handling of nullability and value extraction. (ModelBuilderExtensions.cs,HistoryTrigger.cs, [1] [2] [3]NanoIdfeatures. (DbExtensionsGraphTests.cs, Plugins/Persistence/EfCore/Abstractions/test/Dosaic.Plugins.Persistence.EfCore.Abstractions.Tests/Database/DbExtensionsGraphTests.csR1)