Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

Handle plus signs in Kubernetes minor version#928

Merged
jkotalik merged 1 commit into
dotnet:masterfrom
Douglas-Cleghorn:master
Mar 3, 2021
Merged

Handle plus signs in Kubernetes minor version#928
jkotalik merged 1 commit into
dotnet:masterfrom
Douglas-Cleghorn:master

Conversation

@Douglas-Cleghorn

@Douglas-Cleghorn Douglas-Cleghorn commented Feb 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #927
Resolves #943

This PR updates Tye's KubectlDetector to handle plus signs in the minor version instead of returning an error message.

kubectl version -o json

{
  "clientVersion": {
    "major": "1",
    "minor": "20",
    "gitVersion": "v1.20.2",
    "gitCommit": "faecb196815e248d3ecfb03c680a4507229c2a56",
    "gitTreeState": "clean",
    "buildDate": "2021-01-13T13:28:09Z",
    "goVersion": "go1.15.5",
    "compiler": "gc",
    "platform": "linux/amd64"
  },
  "serverVersion": {
    "major": "1",
    "minor": "20+",
    "gitVersion": "v1.20.1-34+e7db93d188d0d1",
    "gitCommit": "e7db93d188d0d12f2fe5336d1b85cdb94cb909d3",
    "gitTreeState": "clean",
    "buildDate": "2021-01-11T23:50:46Z",
    "goVersion": "go1.15.6",
    "compiler": "gc",
    "platform": "linux/amd64"
  }
}

This line is the problem:

"minor": "20+",

@Douglas-Cleghorn

Douglas-Cleghorn commented Feb 12, 2021

Copy link
Copy Markdown
Contributor Author

Would it be better if it removed all non-numeric characters?

Something like:
Regex.Replace("20+", "[^0-9]", "")

@jkotalik

jkotalik commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

I think this is fine for now.

@jkotalik jkotalik merged commit 2239325 into dotnet:master Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl Awaiting requested review from davidfowl

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

@rynowak rynowak Awaiting requested review from rynowak

1 more reviewer

@jkotalik jkotalik jkotalik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

microk8s serverVersion can't be parsed Error parsing Kubernetes minor version with extra characters (+)

2 participants

@Douglas-Cleghorn @jkotalik