This repository was archived by the owner on Nov 20, 2023. It is now read-only.
#1158 Feature/dashboard port in tye yaml#1163
Merged
philliphoff merged 6 commits intoSep 30, 2021
Merged
Conversation
…gument is not specified)
|
|
philliphoff
reviewed
Sep 29, 2021
philliphoff
approved these changes
Sep 29, 2021
philliphoff
left a comment
Contributor
There was a problem hiding this comment.
Looks good, with just one comment re: the configuration file schema. The additional tests are very much appreciated, too.
Contributor
Author
|
I've added the requested change into the schema file. Thanks again for the great project :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature implementation for #1158
It is a relatively small, and self-contained change with tests added, but I understand if it isn't something you want implemented in this project! Submitting this PR to further discussion in the #1158 issue.
Thank again for everything, I've reaally enjoyed using Tye over the past six months or so.