This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Added support for additional routes on the Dashboard#1200
Merged
Conversation
|
|
Contributor
Author
|
Is there anything I can help with to get this going? |
Member
|
Some design feedback: Routes should be an array instead of a semicolon delimited String |
Contributor
Author
Thanks for the feedback, I have applied the requested changes. |
|
Any traction on this? Looking like it's closer now :) |
Contributor
|
@ante-maric Looks good to me, and rather handy! Thanks for the submission! The only change I've made is to use blocks for the binding spans, as it starts to get hard to read with many routes. @ravipal Since I've made changes myself, can you review as well? |
ravipal
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers issue #618 for supporting additional routes on the Dashboard in Bindings column. This makes it easier to navigate to endpoints that you access frequently like /swagger.