ignore nullable annotations for reference types / type parameters #79109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
reviewed
Jun 24, 2025
Use AllIgnoreOptions as suggested
jcouv
reviewed
Sep 25, 2025
|
|
||
| // As mentioned above, we relax this restriction. The types must all be the same. | ||
|
|
||
| bool typesAreSame = TypeSymbol.Equals(signature.LeftType, signature.RightType, TypeCompareKind.ConsiderEverything2) && TypeSymbol.Equals(signature.LeftType, signature.ReturnType, TypeCompareKind.ConsiderEverything2); |
Member
There was a problem hiding this comment.
Should those checks be relaxed as well?
Contributor
|
@bernd5 Please adjust the title to accurately reflect the scope of the change. We wouldn't want to "ignore nullable annotations for reference types / type parameters" in every possible situation. |
Contributor
|
Also, please resolve merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79098
Because of #nullable we see difference in the nullable annotation of type parameters...
For this check they should be ignored