Skip to content

Add Android support to System.IO.Ports #95749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 1 commit into from
Dec 7, 2023
Merged

Add Android support to System.IO.Ports #95749

akoeplinger merged 1 commit into from
Dec 7, 2023

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Dec 7, 2023

Fixes #86619

Also removes unused HAVE_TERMIOS2_EXITCODE from tryrun.cmake, the HAVE_TERMIOS2 check is not a tryrun one but a compile check.

@akoeplinger
Add Android support to System.IO.Ports
5115016 
Fixes dotnet#86619

Also removes unused HAVE_TERMIOS2_EXITCODE from tryrun.cmake, the HAVE_TERMIOS2 check is not a tryrun one but a compile check.
@akoeplinger akoeplinger requested a review from wfurt December 7, 2023 16:05
@ghost
Copy link

ghost commented Dec 7, 2023

Tagging subscribers to this area: @dotnet/area-system-io-ports
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86619

Also removes unused HAVE_TERMIOS2_EXITCODE from tryrun.cmake, the HAVE_TERMIOS2 check is not a tryrun one but a compile check.

Author: akoeplinger
Assignees: -
Labels:

area-System.IO.Ports
Milestone: -

@ghost ghost assigned akoeplinger Dec 7, 2023
wfurt
wfurt approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akoeplinger akoeplinger merged commit f1d2587 into dotnet:main Dec 7, 2023
@akoeplinger akoeplinger deleted the add-android-ioports branch December 7, 2023 22:55
@wfurt
Copy link
Member

wfurt commented Dec 8, 2023

The package now fails to restore


    <PackageReference Include="System.IO.Ports" Version="9.0.0-alpha.1.23608.3" />


furt@ubu20:~/projects/sslTest$ ~/dotnet-8/dotnet restore
  Determining projects to restore...
/home/furt/projects/sslTest/sslTest.csproj : error NU1101: Unable to find package runtime.android-arm.runtime.native.System.IO.Ports. No packages exist with this id in source(s): dotnet-labs, dotnet6, dotnet7, dotnet8, dotnet9, nuget.org
/home/furt/projects/sslTest/sslTest.csproj : error NU1101: Unable to find package runtime.android-arm64.runtime.native.System.IO.Ports. No packages exist with this id in source(s): dotnet-labs, dotnet6, dotnet7, dotnet8, dotnet9, nuget.org
/home/furt/projects/sslTest/sslTest.csproj : error NU1101: Unable to find package runtime.android-x64.runtime.native.System.IO.Ports. No packages exist with this id in source(s): dotnet-labs, dotnet6, dotnet7, dotnet8, dotnet9, nuget.org
/home/furt/projects/sslTest/sslTest.csproj : error NU1101: Unable to find package runtime.android-x86.runtime.native.System.IO.Ports. No packages exist with this id in source(s): dotnet-labs, dotnet6, dotnet7, dotnet8, dotnet9, nuget.org
  Failed to restore /home/furt/projects/sslTest/sslTest.csproj (in 774 ms).

It is curious that I see runtime.linux-bionic-arm64.runtime.native.System.IO.Ports that was added by this PR but not the android.
https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet9

I'm wondering if there is some patter filter for package publishing...???
cc: @ViktorHofer for infra angle.

@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 9, 2023 •
edited
Loading

Do we have official build CI legs that build the native binaries, i.e. runtime.android-arm.runtime.native.System.IO.Ports? If not then we would need to add them.

This PR broke consuming the System.IO.Ports nuget package, so we should probably revert it until we found the fix.

@akoeplinger
Copy link
Member Author

akoeplinger commented Dec 16, 2023

The package issue was fixed with #96026

akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Dec 16, 2023
@akoeplinger
Remove Android from UnsupportedOSPlatforms in System.IO.Ports
b9aaaa8 
Forgot to do this when I enabled Android in dotnet#95749
@akoeplinger akoeplinger mentioned this pull request Dec 16, 2023
Merged
akoeplinger added a commit that referenced this pull request Dec 16, 2023
@akoeplinger
Remove Android from UnsupportedOSPlatforms in System.IO.Ports (#96087)
f7273b5 
Forgot to do this when I enabled Android in #95749
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt wfurt approved these changes

Assignees

@akoeplinger akoeplinger

Labels

area-System.IO.Ports

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SerialPort is not supported on Android ?

3 participants

@akoeplinger @wfurt @ViktorHofer