[Infra] Add timeout info to dashboard#119
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive timeout tracking and visualization to the skill-validator system. When scenarios exceed their configured timeout, this information is now captured, propagated through the evaluation pipeline, and displayed in both console output and the dashboard UI.
Changes:
- Added
TimedOutboolean property toRunMetricsandScenarioComparisonmodels - Enhanced AgentRunner to catch
TimeoutException, record it as an event, and set the timeout flag - Updated console reporter and markdown reporter to show timeout indicators with ⏰ emoji
- Modified dashboard to display timed-out scenarios with red diamond markers and a summary card
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/skill-validator/src/Models/Models.cs | Added TimedOut property to RunMetrics and ScenarioComparison |
| eng/skill-validator/src/Services/AgentRunner.cs | Added TimeoutException handler to capture timeout events and set TimedOut flag |
| eng/skill-validator/src/Commands/ValidateCommand.cs | Added timeout propagation logic and warning output for timed-out scenarios |
| eng/skill-validator/src/Services/Reporter.cs | Added timeout indicators in console and markdown output with ⏰ emoji |
| eng/dashboard/generate-benchmark-data.ps1 | Added timedOut flag propagation to benchmark data entries |
| eng/dashboard/dashboard.js | Added timeout visualization with red diamond markers, summary card, and tooltips |
| eng/dashboard/dashboard.html | Added --timeout CSS variable for consistent timeout color (#f85149) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # eng/skill-validator/src/Services/Reporter.cs
ViktorHofer
approved these changes
Feb 25, 2026
Contributor
Skill Validation Results
Model: claude-opus-4.6 | Judge: claude-opus-4.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample