Skip to content

feat(dify): add baseUrlOverride to allow dify.baseUrl to be changed independently to host and enableTLS #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LeoQuote merged 4 commits into from
Oct 23, 2025
Merged

feat(dify): add baseUrlOverride to allow dify.baseUrl to be changed independently to host and enableTLS #144

LeoQuote merged 4 commits into from
Oct 23, 2025

Conversation

@tianweiliu
Copy link
Contributor

@tianweiliu tianweiliu commented Oct 22, 2025 •
edited by LeoQuote
Loading

  • Add global.baseUrlOverride configuration option to override dify.baseUrl
  • Maintains backward compatibility with host, port and enableTLS behavior
  • Update README with baseUrlOverride documentation
  • Bumped chart version to 0.7.1

fix #143

@tianweiliu
feat(dify): add externalProtocol flag to set baseURL protocol indepen…
ecfc8a4 
…dently from enableTLS

- Add global.externalProtocol configuration option to override protocol
- Allows setting HTTPS baseURL when TLS terminates externally
- Maintains backward compatibility with enableTLS behavior
- Update README with external TLS termination documentation
@tianweiliu
chore(dify): bump chart version to 0.7.1
90f3dd9
@LeoQuote
Copy link
Contributor

LeoQuote commented Oct 23, 2025

Thank you for your PR. Your requirement is to override the baseURL. It is highly recommended that you set a value named overrideBaseUrl. If this value exists, it can directly override dify.baseUrl unconditionally. This way, it can accommodate a broader range of custom needs, such as the inconsistency between the lb domain name and k8s ingress domain name. Furthermore, this approach is more explicit in terms of intention and usage.

@tianweiliu
Revert "feat(dify): add externalProtocol flag to set baseURL protocol…
680b6c8 
… independently from enableTLS"

This reverts commit ecfc8a4.
@tianweiliu
feat(dify): add baseUrlOverride for explicit base URL control
ab1258a 
- Add global.baseUrlOverride configuration option to directly override the base URL
- When set, baseUrlOverride takes precedence over host, port, and enableTLS
- More explicit and accommodates custom needs like LB domain vs k8s ingress domain
- Update documentation with examples and use cases
- Bump chart version to 0.7.1
@tianweiliu tianweiliu changed the title feat(dify): add externalProtocol flag to set baseURL protocol independently from enableTLS feat(dify): add baseUrlOverride to override dify.baseURL generated from host, port and enableTLS Oct 23, 2025
@tianweiliu tianweiliu changed the title feat(dify): add baseUrlOverride to override dify.baseURL generated from host, port and enableTLS feat(dify): add baseUrlOverride to allow dify.baseURL to be changed independently to host and enableTLS Oct 23, 2025
@tianweiliu tianweiliu changed the title feat(dify): add baseUrlOverride to allow dify.baseURL to be changed independently to host and enableTLS feat(dify): add baseUrlOverride to allow dify.baseUrl to be changed independently to host and enableTLS Oct 23, 2025
@tianweiliu
Copy link
Contributor Author

tianweiliu commented Oct 23, 2025

@LeoQuote Thank you for your comment. I have reverted my previous change and implemented what you described.

@LeoQuote LeoQuote merged commit 2ab20ba into douban:master Oct 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

De-couple enableTLS with dify.baseUrl

2 participants

@tianweiliu @LeoQuote