Misc nice to have changes #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not doing it for the default path ~/.drand, because if a user can't write to their home directory they got issues anyway Also preventing invalid -db values to start with bolt without erroring
CluEleSsUK
reviewed
May 17, 2024
CluEleSsUK
reviewed
May 17, 2024
CluEleSsUK
reviewed
May 17, 2024
Co-authored-by: PM <3749956+CluEleSsUK@users.noreply.github.com>
CluEleSsUK
approved these changes
May 17, 2024
CluEleSsUK
added a commit
that referenced
this pull request
Jun 28, 2024
* Adding read/write test and log when using custom folder Not doing it for the default path ~/.drand, because if a user can't write to their home directory they got issues anyway Also preventing invalid -db values to start with bolt without erroring * remove comment * Dedis proofing * Update common/key/store.go Co-authored-by: PM <3749956+CluEleSsUK@users.noreply.github.com>
AnomalRoil
added a commit
that referenced
this pull request
Jun 28, 2024
* Adding read/write test and log when using custom folder Not doing it for the default path ~/.drand, because if a user can't write to their home directory they got issues anyway Also preventing invalid -db values to start with bolt without erroring * remove comment * Dedis proofing * Update common/key/store.go Co-authored-by: PM <3749956+CluEleSsUK@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing it for the default path ~/.drand, because if a user can't write to their home directory they got issues anyway
Also preventing invalid -db values to start with bolt without erroring.