added support for new g1-rfc9380 scheme #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnomalRoil
approved these changes
Jun 27, 2023
Member
AnomalRoil
left a comment
There was a problem hiding this comment.
LGTM I guess, but would be nice to avoid carrying that tech debt of retro-compat of non-compliant verification forever.
Comment on lines
+64
to
+65
| // default DST is the invalid one used for 'bls-unchained-on-g1' for backwards compat | ||
| domainSeparationTag= 'BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_NUL_' |
Member
There was a problem hiding this comment.
Gosh, I hate this. But I guess it's the only way not to break things for people T.T
Are we sure people are actually using this function directly?
Could we avoid doing this? In the code above we could be explicit for each scheme...
Contributor
Author
There was a problem hiding this comment.
we could make it mandatory, but we'd have to bump to v2 to make sure nobody gets pwned by it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.