versioning now gets added at compile time to avoid reshaping the build #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnomalRoil
approved these changes
Feb 9, 2023
8e1776c to
d6527b6
Compare
AnomalRoil
approved these changes
Feb 9, 2023
| let chainToUse | ||
| for (const chain of chains) { | ||
| const info = await chain.info() | ||
| if (info.schemeID === 'pedersen-bls-chained' || info.schemeID === 'pedersen-bls-unchained') { |
Member
There was a problem hiding this comment.
What if it's "bls-unchained-on-g1" ??
Contributor
Author
There was a problem hiding this comment.
We don't test it because we don't support it. This test started breaking because it previously assumed chains[0] was one that it could process. Since we added testnet-g, it is now chains[0] and blows up.
Once we merge a fix for the g1 swap, we can revert this (and just test against all the networks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dir