Skip to content

fix multi stage approvals#444

Merged
d1wilko merged 1 commit into
mainfrom
ci-8780
Aug 10, 2023
Merged

fix multi stage approvals#444
d1wilko merged 1 commit into
mainfrom
ci-8780

Conversation

@d1wilko

@d1wilko d1wilko commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@d1wilko d1wilko requested a review from tphoney August 10, 2023 13:11
@d1wilko d1wilko merged commit 7a768d5 into main Aug 10, 2023
@d1wilko d1wilko deleted the ci-8780 branch August 10, 2023 13:12

@tphoney tphoney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xoxys

xoxys commented Aug 11, 2023

Copy link
Copy Markdown

@d1wilko What about the handleDeclineClick function at https://github.com/drone/drone-ui/pull/444/files#diff-c46c5904431a32dac3754d9b976f06034e454bc8026432e9aa29e7fb37c26b84R208? It has the same issue and was not fixed.

@d1wilko

d1wilko commented Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

@xoxys yes good point - will raise another PR - I had a bit of tunnel vision 😳

@xoxys

xoxys commented Aug 11, 2023

Copy link
Copy Markdown

No worries, thanks!

@d1wilko

d1wilko commented Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

@xoxys PR is here :) - #446

changes should be in the drone "latest" tag in the next hour or so

@d1wilko d1wilko added the bug label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants