MultiSelectInput #144
MultiSelectInput #144
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| onChange(value.filter((i) => i !== item)); | ||
| }} | ||
| > | ||
| <XIcon className="w-3" /> |
There was a problem hiding this comment.
Hitting X, places the item on the input. Is this supposed to be the default behaviour?
There was a problem hiding this comment.
no I changed this one myself. thought it could be useful if want to edit an existing value instead of deleting
| value, | ||
| onChange, | ||
| ...props | ||
| }: MultiTagInputProps) { |
There was a problem hiding this comment.
Maybe this is nitpicking, but this could have a maxItems so the user doesn’t add an infinite number of items.
There was a problem hiding this comment.
seems like that would be a job for the zod schema, not for here, because it's very dependant on the use case
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new MultiTagInput component with form integration while cleaning up build configuration and dependencies. The changes improve TypeScript configuration to properly include story files, remove unnecessary lint suppression comments, and update various dependencies including Biome and Storybook.
Key Changes:
- Added new MultiTagInput component with standalone and form-integrated variants
- Updated biome configuration to support React classic JSX runtime, eliminating the need for React import suppressions
- Updated multiple dependencies including TypeScript, Biome, and Storybook packages
Reviewed Changes
Copilot reviewed 24 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Updated include paths to properly include source and Storybook files |
| biome.json | Added jsxRuntime configuration for React classic mode |
| package.json | Updated Biome, Storybook, and TypeScript dependency versions |
| components/MultiTagInput.tsx | New standalone MultiTagInput component implementation |
| components/form/index.tsx | Added MultiTagInput form wrapper component |
| stories/forms/MultiTagInput.stories.tsx | Added stories showcasing MultiTagInput usage |
| stories/*.stories.tsx | Removed biome-ignore comments for React imports |
| stories/forms/*.stories.tsx | Standardized React imports and fixed useEffect dependencies |
| lib/utils.tsx | Added radix parameter to parseInt |
| components/infinite-scroll.tsx | Updated ts-ignore to ts-expect-error |
| .storybook/preview.tsx | Removed unused React import |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.