Feature/playback get imu sample #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry, I did not notice this PR until today! Thanks for the contribution, this looks well done. @shagren it seems perfect but could you test? |
shagren
suggested changes
Dec 15, 2021
| thread_safe=self.thread_safe, | ||
| ) | ||
|
|
||
| def get_next_imu_sample(self) -> Optional["ImuSample"]: |
Contributor
There was a problem hiding this comment.
Please add
from .pyk4a import ImuSamplebefore
from .results import Result, StreamResult
pyk4a/pyk4a.cpp
Outdated
Comment on lines
1334
to
1337
| imu_sample.acc_sample.xyz.x, imu_sample.acc_sample.xyz.y, imu_sample.acc_sample.xyz.z, | ||
| "acc_timestamp", imu_sample.acc_timestamp_usec, "gyro_sample", imu_sample.gyro_sample.xyz.x, | ||
| imu_sample.gyro_sample.xyz.y, imu_sample.gyro_sample.xyz.z, "gyro_timestamp", | ||
| imu_sample.gyro_timestamp_usec); |
Contributor
There was a problem hiding this comment.
Suggested change
| imu_sample.acc_sample.xyz.x, imu_sample.acc_sample.xyz.y, imu_sample.acc_sample.xyz.z, | |
| "acc_timestamp", imu_sample.acc_timestamp_usec, "gyro_sample", imu_sample.gyro_sample.xyz.x, | |
| imu_sample.gyro_sample.xyz.y, imu_sample.gyro_sample.xyz.z, "gyro_timestamp", | |
| imu_sample.gyro_timestamp_usec); | |
| imu_sample.acc_sample.xyz.x, imu_sample.acc_sample.xyz.y, imu_sample.acc_sample.xyz.z, | |
| "acc_timestamp", imu_sample.acc_timestamp_usec, "gyro_sample", imu_sample.gyro_sample.xyz.x, | |
| imu_sample.gyro_sample.xyz.y, imu_sample.gyro_sample.xyz.z, "gyro_timestamp", | |
| imu_sample.gyro_timestamp_usec); |
Just remove 2 spaces on these lines
…port in playback.py
Contributor
Author
|
Sorry, now I didn't see your comments for a long time. Hopefully this can be closed soon now. :) |
Codecov Report
@@ Coverage Diff @@
## develop #150 +/- ##
===========================================
+ Coverage 81.23% 81.38% +0.14%
===========================================
Files 12 12
Lines 762 768 +6
===========================================
+ Hits 619 625 +6
Misses 143 143
Continue to review full report at Codecov.
|
lpasselin
added a commit
that referenced
this pull request
May 27, 2022
* Feature/playback get imu sample (#150) * feat(playback-imu-sample): add "get_next_imu_sample" to playback * fix(playback-imu-sample): PR changes, add correct indentation, add import in playback.py * add info related to conda and DLL not found error * update black version (fix click bug) (#168) * update black version (fix click bug) * black reformat * fix typo Co-authored-by: Louis-Philippe Asselin <lpasselin@users.noreply.github.com> Co-authored-by: annStein <43335656+annStein@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For playback.py I added the method to get the next imu sample.