Skip to content

2FA #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
biow0lf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

2FA #3919

biow0lf wants to merge 2 commits into from

Conversation

@biow0lf
Copy link
Member

@biow0lf biow0lf commented Apr 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 98.59% and project coverage change: -0.02 ⚠️

Comparison is base (452f98b) 99.07% compared to head (e00cd5e) 99.06%.

❗ Current head e00cd5e differs from pull request most recent head 68280bd. Consider uploading reports for the commit 68280bd to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3919      +/-   ##
==========================================
- Coverage   99.07%   99.06%   -0.02%     
==========================================
  Files         529      535       +6     
  Lines        4439     4485      +46     
  Branches      212      219       +7     
==========================================
+ Hits         4398     4443      +45     
- Misses         41       42       +1
Impacted Files Coverage Δ
app/views/profiles/show.html.erb 100.00% <ø> (ø)
app/views/devise/sessions/_form.html.erb 94.73% <94.73%> (ø)
app/controllers/two_factors_controller.rb 100.00% <100.00%> (ø)
app/controllers/users/sessions_controller.rb 100.00% <100.00%> (ø)
app/models/user.rb 100.00% <100.00%> (ø)
app/views/devise/sessions/new.html.erb 100.00% <100.00%> (+5.55%) ⬆️
app/views/devise/sessions/pre_otp.turbo_stream.erb 100.00% <100.00%> (ø)
app/views/two_factors/_two_factor_auth.html.erb 100.00% <100.00%> (ø)
app/views/two_factors/create.turbo_stream.erb 100.00% <100.00%> (ø)
app/views/two_factors/destroy.turbo_stream.erb 100.00% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@biow0lf biow0lf force-pushed the 2fa branch 16 times, most recently from 3d484d9 to f787263 Compare April 10, 2023 10:27
@biow0lf biow0lf force-pushed the 2fa branch 9 times, most recently from e6fd21b to 4a67f23 Compare April 16, 2023 15:57
@biow0lf biow0lf force-pushed the 2fa branch 4 times, most recently from 95fe5ed to 1d43859 Compare April 20, 2023 13:26
@biow0lf biow0lf force-pushed the 2fa branch 3 times, most recently from 307aac8 to a36c0df Compare April 24, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@biow0lf