Try using super() to prevent recursion #750
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
=======================================
+ Coverage 43% 53% +9%
=======================================
Files 88 88
Lines 12342 9907 -2435
Branches 1803 1747 -56
=======================================
- Hits 5421 5281 -140
+ Misses 6516 4271 -2245
+ Partials 405 355 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
temoto
reviewed
Feb 23, 2022
| _original_wrap_socket.__globals__['SSLContext'] = tmp_sslcontext | ||
| _original_sslsocket._create.__globals__['SSLSocket'] = tmp_sslsocket | ||
| _original_wrap_socket.__globals__["SSLContext"] = tmp_sslcontext | ||
| _original_sslsocket.sslsocket_class._create.__globals__[ |
Member
There was a problem hiding this comment.
please don't shrink it
there's max-line-width = 123 in tox.ini
if you want to introduce black formatter it's very much welcome in separate patch, with 123 width
Contributor
|
Can you explain the purpose of this PR? Thank you! |
itamarst
requested changes
Dec 22, 2023
Contributor
itamarst
left a comment
There was a problem hiding this comment.
Please explain the motivation for this PR, it's unclear to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.