-
Notifications
You must be signed in to change notification settings - Fork 633
Release 1.2.6 #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 1.2.6 #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… must be prevented
…eventmachine#766)" This reverts commit 3621c04.
The unbind callback absolutely must not raise an exception or the reactor will crash. If there is no EM.error_handler, or if the error_handler retrows, then stop the reactor, stash the exception in $wrapped_exception, and the exception will be raised after the reactor is cleaned up (see the last line of self.run). This fixes many crash reports in the 1.2 series since eventmachine#327 was merged.
…or (eventmachine#801) This method exists in the cpp version but not in the pure ruby version. When there is an undelivered message for example, it will attempt to check the socket status and fail saying that the method report_connection_error_status does not exist. This is in turn causes the connection to fail. It will not return the socket status.
454ecbd to
b7d3685
Compare
…tmachine#831) This resolves the conflict of socket bind() vs std::bind(), as more std:: functions may be introduced in future versions of C++. Resolves eventmachine#830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.