Skip to content

Add example command for extension #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glensc merged 3 commits into from
Sep 28, 2021
Merged

Add example command for extension #1216

glensc merged 3 commits into from
Sep 28, 2021

Conversation

@vladsf
Copy link
Contributor

@vladsf vladsf commented Sep 27, 2021 •
edited
Loading

Here is an example command I trying to add to a release of Eventum, but I get
the error:

[eventumtest Command]$ /eventum/bin/console.php eventum:example:hello
  There are no commands defined in the "eventum:example" namespace.
..

Not sure I understand how to add custom console commands.
Also there is discussion for this case.

@glensc
Copy link
Member

glensc commented Sep 28, 2021 •
edited
Loading

You needed to run cache:clear:

$ ./bin/console.php cache:clear
[...]
$ ./bin/console.php eventum:example:hello
Hello world!

docs:

@glensc
Copy link
Member

glensc commented Sep 28, 2021

In other words, you need to clear the cache for the dependency injection:

ps: cross-link this PR and your discussion for other people!

@glensc glensc changed the title Add example command Add example command for extension Sep 28, 2021
@glensc glensc marked this pull request as ready for review September 28, 2021 04:57
@glensc
Copy link
Member

glensc commented Sep 28, 2021

I've refactored the class to move it to extension, so this can be merged.

@glensc glensc merged commit a9ab07f into eventum:master Sep 28, 2021
@glensc
Copy link
Member

glensc commented Sep 28, 2021

@vladsf by crosslink I mean that both have links to each other, right now PR does not have a link to the discussion.

@vladsf vladsf deleted the add-example-cmd branch September 28, 2021 12:56
@glensc glensc added this to the 3.10.7 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

3.10.7

Development

Successfully merging this pull request may close these issues.

2 participants

@vladsf @glensc