refactor rulesets into separate files and add a ruleset compiler cli …#41
Merged
Merged
Conversation
Contributor
|
My first intention was to create a bash script. But this is way better.
Writing an action to install the binary and generate the rules is a challenge. But I think I can handle that. |
mms-gianni
reviewed
Nov 16, 2023
| } `yaml:"urlMods"` | ||
| Domain []Regex `yaml:"domain,omitempty"` | ||
| Path []Regex `yaml:"path,omitempty"` | ||
| Query []KV `yaml:"queryomitempty"` |
Contributor
There was a problem hiding this comment.
Found this typo and fixed it 😄
andesco
pushed a commit
to andesco/ladder
that referenced
this pull request
Sep 15, 2025
refactor rulesets into separate files and add a ruleset compiler cli …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
ruleset.yamlinto an organized directory of smaller rulesets.Create a CLI option
--merge-rulesetand--merge-ruleset-gzipthat optionally merges the rulesets into a single file for release.I'm not familiar enough with Github CI/CD and goreleaser to make changes with the releaser, but ideally the ruleset.yaml should be distributed with the release files.
Something like this in
.github/workflows/release-binaries.yaml