Skip to content

Conversation

@Sedictious
Copy link
Contributor

@Sedictious Sedictious commented Jul 4, 2019

Simply initialize an empty page when pushing the "graph" button (uses the project button as a placeholder). This is a WIP but should be enough to give the general idea of a possible implementation.

(Solved) The commit messes up the spacing of the toolbar, but I'll fix this once I find out how Qt wspacer works exactly.

Update: 54fd499 added a simple (non yet functional) GraphDesigner which is pretty much an ExperimentDesigner with only the graph functionality present. One issue that needs to be addressed is the way attributes are handled; without an experiment we must have a way of specifying the number of attributes and perhaps other properties directly from the designer.

I opted out from making the GraphDesigner a DockWindow as I think only one graph should be able to be opened at any time and unlike the Experiment Designer, having a main page isn't necessary. But of course, I'm always open to suggestions :)

@cardinot
Copy link
Member

cardinot commented Jul 9, 2019

I opted out from making the GraphDesigner a DockWindow as I think only one graph should be able to be opened at any time and unlike the Experiment Designer, having a main page isn't necessary. But of course, I'm always open to suggestions :)

I'm ok with opening one graph/grid at a time. However, do you have plans to implement the "full inspector" widget that we discussed earlier? In this case, how would we be able to dock the inspector widget in the GraphDesigner if it's not a window? 🤔

@Sedictious
Copy link
Contributor Author

@cardinot I was planning to have a separate GraphDesignerWindow class which would be initialized after setting up all the parameters. However, if this is the case, maybe it's worth considering remaining GraphDesigner to something like GraphDesignerSettings.

@cardinot
Copy link
Member

cardinot commented Jul 9, 2019

@cardinot I was planning to have a separate GraphDesignerWindow class which would be initialized after setting up all the parameters. However, if this is the case, maybe it's worth considering remaining GraphDesigner to something like GraphDesignerSettings.

so, are you planning to open the "new graph" settings in place? (instead of a popup dialog)
I'll compile and test the existing code later, but, in this case, what will happen when I close the graph? Will you close the "graph window" and send me back to the "graph settings" page?

@Sedictious
Copy link
Contributor Author

@cardinot I was actually planning that closing the graph would return you to the graph designer main page (the one with "New Graph" and "Open Graph")

* This file is part of Evoplex.
*
* Evoplex is a multi-agent system for networks.
* Copyright (C) 2018 - Marcos Cardinot <marcos@cardinot.net>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following the license template, here we write the author's name for the file; so, feel free to replace it with your name

@cardinot cardinot merged commit 677e1ee into evoplex:socis19 Jul 14, 2019
Sedictious added a commit to Sedictious/evoplex that referenced this pull request Jul 24, 2019
* Add non-functional graph designer button

* Add graph page

* Add graph designer landing page

* Remove graphpage.ui

* Fix toolbar spacing

* Add signals for creating graphs

* Add graph designer widget

* Add attribute table in Graph Designer

* Remove extra attributes for now

* Add cancel button

* Make close button functional

* 'Add button' icon and minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants