Feature/Sheet Protection #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh/exceljs into feature/sheet-protection
Signed-off-by: Karabaesh <karabaesh@users.noreply.github.com>
Siemienik
approved these changes
Aug 7, 2019
Member
Siemienik
left a comment
There was a problem hiding this comment.
Cool, It's a great request:)
Everything from code side looks fine for me, so I approve it.
Could anyone confirm that this feature works fine?
guyonroche
requested changes
Aug 12, 2019
Collaborator
guyonroche
left a comment
There was a problem hiding this comment.
@karabaesh Thank you for working on this PR - it will be a great addition to exceljs
I've made a few comments - could you take a look?
guyonroche
requested changes
Aug 12, 2019
karabaesh
commented
Aug 13, 2019
Contributor
Author
karabaesh
left a comment
There was a problem hiding this comment.
Applied some changed according to guyonroche's requests.
guyonroche
requested changes
Aug 13, 2019
karabaesh
commented
Aug 14, 2019
Contributor
Author
karabaesh
left a comment
There was a problem hiding this comment.
Changes have been implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: