feat: asignatura screen #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Se agrega Top Navigation con un condicional para saber si es una screen principal o secundaria - Si isMainScreen = true se agrega la imagen del perfil y los (⁝) - Si isMainScreen = false se agrega la flecha atrás para hacer pop() - Se elimina el espacio debajo del statusBar de Android (no fué testeado en iOS) - Se eliminan sombreados de algunas Cards
# Conflicts: # lib/screens/asignaturas/asignaturas_screen.dart # lib/screens/home/home_screen.dart # lib/screens/tasklist/task_list_screen.dart # lib/widgets/navigation/bottom_navbar.dart
# Conflicts: # lib/core/utils/theme.dart # lib/main.dart # lib/screens/asignaturas/asignaturas_screen.dart # lib/screens/home/home_screen.dart # lib/screens/profile/profile_screen.dart # lib/screens/tasklist/task_list_screen.dart # lib/screens/widgets_screens.dart # lib/styles/navigation/bottom_navbar.dart # lib/widgets/navigation/top_navigation.dart
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a comprehensive subject details screen feature alongside dependency updates and improved navigation with feature flags. The main purpose is to enhance the user experience by providing detailed subject information including grades and schedules, while also implementing a flexible feature flag system for navigation control.
- Adds a new detailed subject screen (
AsignaturaScreen) with grades and schedule visualization - Implements feature flag system for conditional UI rendering and navigation control
- Updates Firebase and other dependencies to newer versions
Reviewed Changes
Copilot reviewed 29 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pubspec.yaml |
Updates Firebase and other package dependencies to newer versions |
macos/Podfile |
Updates Firebase Firestore SDK and platform target |
lib/widgets/feature_flag.dart |
Adds comprehensive feature flag system for conditional UI rendering |
lib/styles/theme/theme.dart |
Updates deprecated theme constructors to new data variants |
lib/styles/navigation/bottom_navbar.dart |
Integrates feature flags into navigation system |
lib/screens/asignaturas/detalle_asignatura/ |
New subject details screen with grades and schedule components |
lib/screens/asignaturas/lista_asignaturas_screen.dart |
Renamed and updated main subjects screen |
lib/screens/notas/notas_screen.dart |
Enhanced notes screen to accept pre-loaded subject data |
lib/core/models/navigation/navigation_item.dart |
Adds feature flag support to navigation items |
Comments suppressed due to low confidence (2)
lib/widgets/feature_flag.dart:261
- The method
withValues(alpha: 0.2)appears to be using a newer Flutter API that may not exist in all Flutter versions. Consider using the more widely supportedwithOpacity(0.2)method instead.
color: isEnabled ? Colors.green.withValues(alpha: 0.2) : Colors.red.withValues(alpha: 0.2),
lib/screens/asignaturas/detalle_asignatura/widgets/promedio.dart:54
- The method
withValues(alpha: 0.2)appears to be using a newer Flutter API that may not exist in all Flutter versions. Consider using the more widely supportedwithOpacity(0.2)method instead.
color: Colors.grey.withValues(alpha: 0.2),
| @@ -1,4 +1,4 @@ | |||
| platform :macos, '11.5' | |||
| platform :osx, '10.15' | |||
There was a problem hiding this comment.
The platform declaration has changed from 'macos' to 'osx', but macOS 10.15 (Catalina) is quite old. Consider using a more recent macOS version like '11.0' or '12.0' for better compatibility with newer Firebase SDKs and features.
Suggested change
| platform :osx, '10.15' | |
| platform :osx, '12.0' |
lib/screens/asignaturas/detalle_asignatura/asignatura_screen.dart
Outdated
Show resolved
Hide resolved
lib/screens/asignaturas/detalle_asignatura/asignatura_screen.dart
Outdated
Show resolved
Hide resolved
Se utiliza otro nombre para la variable para evitar `shadowing` Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esta solicitud de extracción introduce varias actualizaciones en múltiples archivos para mejorar la funcionalidad, mejorar la experiencia del usuario y optimizar la organización del código. Los cambios más significativos incluyen actualizar el SDK de Firebase Firestore, agregar nuevas pantallas y widgets para mostrar información detallada del tema y refactorizar el código existente para una mejor modularidad.
Actualizaciones de dependencia:
11.4.0a11.15.0en elios/Podfile.Nuevas Características:
Pantalla de detalles del tema: Se agregó
AsignaturaScreenpara mostrar información detallada del tema, incluidas las calificaciones y los horarios. Esta pantalla captura calificaciones de forma asíncrona y proporciona funcionalidad de actualización.Funcionalidad de carga de calificaciones: Se agregó la función
cargarAsignaturaConNotaspara obtener calificaciones para un tema específico.Programar análisis y visualización:
Se introdujo el modelo
HorarioBloquepara representar los bloques de programación.Se agregó el widget
CardHorariopara mostrar visualmente los bloques de programación.Implementó el widget
SeccionHorariopara analizar y mostrar los horarios de los temas.Refactorización:
Navegación de la lista de temas: Se ha modificado
ListaAsignaturaspara navegar a la nuevaAsignaturaScreencuando se toca una tarjeta de tema.Mejoras de la estructura de archivos: Rutas de importación actualizadas para una mejor organización, como mover acciones de
AccesoRapidoa una carpeta dedicada.Mejoras menores: