Skip to content

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Jun 19, 2025

Why

It's faster. We can still type-check in a separate step in CI, or locally.

Test Plan

All test scripts are still runnable, including in CI.

Copy link
Member Author

nicknovitski commented Jun 19, 2025

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (6cecd9f) to head (2ff0f1f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #294      +/-   ##
===========================================
- Coverage   100.00%   99.78%   -0.22%     
===========================================
  Files           82       77       -5     
  Lines         2287     1879     -408     
  Branches       251      251              
===========================================
- Hits          2287     1875     -412     
- Misses           0        4       +4     
Flag Coverage Δ
integration 99.78% <ø> (-0.22%) ⬇️
unittest 99.78% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicknovitski nicknovitski marked this pull request as ready for review June 19, 2025 20:45
@nicknovitski nicknovitski requested a review from wschurman as a code owner June 19, 2025 20:45
@wschurman wschurman changed the title Replace ts-jest with babel-jest chore: Replace ts-jest with babel-jest Jun 20, 2025
Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a test plan (ditto). can just be "Run tests in CI"

Copy link
Member Author

nicknovitski commented Jun 20, 2025

Merge activity

  • Jun 20, 7:07 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 20, 7:08 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 20, 7:14 PM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski changed the base branch from jest-types to graphite-base/294 June 20, 2025 19:07
@nicknovitski nicknovitski changed the base branch from graphite-base/294 to main June 20, 2025 19:07
@nicknovitski nicknovitski merged commit 1fd0144 into main Jun 20, 2025
3 of 4 checks passed
@nicknovitski nicknovitski deleted the babel-jest branch June 20, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants