Skip to content

Port Refactorex into Expert #678

Description

@doorgan

Refactorex is an excellent project that we depend on for several code actions.

However its original use case was different and integrating it with expert has some compatibility issues, mainly around dealing with offset conversions, or odd corner cases we've found from expert users.

I think it's worth to port its features(with proper attribution) into expert itself for two reasons:

  • To eliminate the compatibility glue and apply expert-specific optimizations where needed
  • To allow us to fix issues quickly, and not put the entire burden on the one maintainer of Refactorex

cc @gp-pereira as the Refactorex author

Activity

  1. added this to the 0.2 milestone on May 27, 2026
  2. katafrakt commented on Jun 23, 2026

    @katafrakt
    Member

    I wonder if we have any more detailed vision for that? Just put the current Refactorex code somewhere and refer to it? Or take the Refactorex features one by one and port them into more Expert-native form? Currently we have 5 PRs open to Refactorex with fixes to bug found in Expert usage, so I think it would be good to address soon, even if no one volunteers for "good first issue".

  3. doorgan commented on Jun 23, 2026

    @doorgan
    ContributorAuthor

    Any of them works, vendoring it inside apps and fixing its crashes works as a first step.
    In the long term I think we want to go over its refactors and port them into a more Expert-native form but I don't think that is required for now.
    The end goal is to be able to fix the issues we have related to it

  4. self-assigned this
    on Jun 24, 2026
  5. added a commit that references this issue on Jul 1, 2026
    131d642
  6. added a commit that references this issue on Jul 2, 2026
    c27bf61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions