Support learner change #571
Conversation
include/libnuraft/msg_type.hxx
Outdated
| learner_change_request = 30, | ||
| learner_change_response = 31, |
There was a problem hiding this comment.
New message types are not needed.
Same as priority change (raft_server::set_priority), we can just create a new config log with updated server config, and replicate it. There is no need for its handler.
https://github.com/eBay/NuRaft/blob/master/src/handle_priority.cxx#L79-L106
There is a special message type priority_change_request, in order to broadcast (temporary) priority change in case when the leader is dead, for the sake of troubleshooting. This shouldn't be the case for learner flag, as changing learner role without leader is not safe.
There was a problem hiding this comment.
I saw there is an auto_forwarding_ parameter, and when enabled, add_srv/remove_srv can be forwarded to leader. Not sure in this scenario if we should allow forwarding for learner change.
|
Remove |
Previously, learner is a static srv config, provide a cmd for use to flip the learner flag.
greensky00
left a comment
There was a problem hiding this comment.
Thanks, fixed some indent.
Previously, learner is a static srv config, provide a cmd for use to flip the learner flag.