feat(handler): implement duplicate read closer for request body #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a utility function `dupReadCloser` that allows duplicating the incoming request body reader. It is now used in the request handling loop to ensure that the request body can be consumed by multiple handlers or middleware without losing the original data.
Pull Request Test Coverage Report for Build 10055591097Details
💛 - Coveralls |
Owner
|
This is a useful feature, but it should not be on by default because it uses too much memory. Instead I think it should look like: handler := requests.KeepResponseBody(
requests.ToJSON(&common),
requests.ToJSON(&book),
requests.ToString(&str),
)What do you think of that? |
Author
i think |
| } | ||
|
|
||
| var dup io.ReadCloser | ||
| r.Body, dup = dupReadCloser(r.Body) |
Owner
There was a problem hiding this comment.
I'm not sure, but I think if one of the handlers only consumed part of the response, the subsequent handlers would only get a partial buffer.
Instead, what if on a new line between line 35 and line 36, it read the whole body into a buffer and reset the buffer on each loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a utility function
dupReadCloserthat allows duplicating the incoming request body reader. It is now used in the request handling loop to ensure that the request body can be consumed by multiple handlers or middleware without losing the original data.