fix: services and medications cannot be on one invoice (backport #642) #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to put Services as well as Medications on one invoice. This is because when ever items are loaded onto an invoice, there is a frm.clear_table instruction in the function set_primary_action in the file ..../public/js/sales_invoice.js.
I propose to move this clear_table to an onload_post_render trigger. This will allow for the items-table to be cleared when a new invoice is created but allows for services as well as medications to be added to the invoice without clearing the table first.
By doing it this way, the user has the choice of putting everything onto one invoice or to use more than one invoice.
closes #583
This is an automatic backport of pull request #642 done by Mergify.