Skip to content

Conversation

@nkorinek
Copy link
Contributor

Adding changes to the crs_check function requested in #707

@nkorinek
Copy link
Contributor Author

@lwasser this pr has the changes you requested on #707

@lwasser
Copy link

lwasser commented Jun 16, 2021

@nkorinek some ci checks failed - looks like a docs issue. can you have a look at that before i review?

@nkorinek
Copy link
Contributor Author

@lwasser passing checks now! The only issue I have is that I can't get full code coverage b/c I don't know how to write a test for hierarchical data. Any idea for that? I'd be surprised if we could do it without adding data to earthpy but was wondering if maybe I wasn't thinking of an easier solution!

@nkorinek
Copy link
Contributor Author

nkorinek commented Jul 1, 2021

Hey @lwasser since this will help with the xarray lessons, and since it's already merged with a few issues, I'm going to merge this pr. There's an open issue with how we still need to expand on this pr, but this is a good start and like I said, we accidentally merged a worse version of this earlier.

@nkorinek nkorinek merged commit ad3de3f into earthlab:main Jul 1, 2021
@lwasser
Copy link

lwasser commented Jul 1, 2021

sounds good @nkorinek !!

@lwasser
Copy link

lwasser commented Jul 1, 2021

@nkorinek we could add a small hierarchical dataset to this in the future. or we could make a fixture that creates one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants