Skip to content

Conversation

@aefitts
Copy link
Contributor

@aefitts aefitts commented Jul 1, 2021

Fixed Linting tests to run both black and flake8 instead of running flake8 twice. Resolving issue #714. @lwasser @nkorinek

@nkorinek nkorinek merged commit 78d166e into earthlab:main Jul 1, 2021
@nkorinek
Copy link
Contributor

nkorinek commented Jul 1, 2021

Merging!

@lwasser
Copy link

lwasser commented Jul 1, 2021

yay @aefitts you just contributed to earthpy!! you rock!

@lwasser
Copy link

lwasser commented Jul 1, 2021

one small note. When you submit a PR try to add this languate to the top:

closes #714

i had an open issue for this and if you write "closes" + the issue url it will automagically close the issue once the PR is merged. it also links the issue to the PR for housekeeping . records!

@lwasser
Copy link

lwasser commented Jul 1, 2021

i know it seems odd but the word closes triggers github to actually close the issue! i do see it's referenced above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants