Added logo, preview and updated readme #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
999fb77 to
a8ed7f8
Compare
Collaborator
|
I think this looks wonderful! Only question is should we put these images inside a folder? (including the root one?) It seems strange that they are hanging out in the root. Maybe a "Media" folder or something like that? |
Contributor
Author
|
Yeah, I can move it. Is "media" will be ok? Some people also names it docs or misc. |
Contributor
Author
|
I moved them. |
Collaborator
|
Uhg, I just realized, this change breaks the newly merged GIF demo. Could you please update the gif demo to be able to find the _media/ebiten-ui.gif |
Contributor
Author
|
Ok, so I just need to sync the fork in order to get it updated I guess? |
Contributor
Author
mcarpenter622
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've made a logo and preview page for dark and light modes.
I'm not sure if you will like, but I also applied the same color scheme to the badges.
I guess we can discuss the changes here.