Add compressed argument to encapsulate/decapsulate functions #141
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a compressed argument to the encapsulate and decapsulate functions across different elliptic curve implementations to eliminate the need for config references within the elliptic module.
- Adds
compressedboolean parameter toencapsulateanddecapsulatefunctions - Updates all function calls to pass the compression flag from config
- Removes direct config dependencies from elliptic curve modules
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Updates function calls to pass is_hkdf_key_compressed() as parameter |
| src/elliptic/secp256k1.rs | Implements compressed parameter and removes config import |
| src/elliptic/x25519.rs | Adds compressed parameter (unused for this curve) |
| src/elliptic/ed25519.rs | Adds compressed parameter (unused for this curve) |
| src/elliptic/mod.rs | Updates test to use new function signature |
| Cargo.toml | Version bump and dependency updates |
| CHANGELOG.md | Documents the API change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
864d2fe to
5acd1bb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 661 665 +4
=========================================
+ Hits 661 665 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
To get rid of config reference in elliptic module